Fix: Error handling for forward() to only take one pandas dataframe #1382
+104
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hello @duanduanzhou, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify that your PR is up-to-date with
georgia-tech-db/evamasterbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.
duanduanzhou
changed the title
xzdandy
reviewed
Nov 28, 2023
| @@ -322,6 +322,22 @@ def test_should_raise_if_function_file_is_modified(self): | |||
| # with self.assertRaises(AssertionError): | |||
| execute_query_fetch_all(self.evadb, select_query) | |||
|
|
|||
| def test_should_raise_error_for_multiple_dataframes(self): | |||
There was a problem hiding this comment.
Let's move this to the short integration tests.
xzdandy
reviewed
Nov 28, 2023
| from evadb.functions.decorators.io_descriptors.data_types import PandasDataframe | ||
|
|
||
|
|
||
| class FuzzDistance(AbstractFunction): |
There was a problem hiding this comment.
We do not need to create a separate file for this function under evadb/functions, since this is not a valid function.
We can directly define this function in the integration test file.
|
This PR fixes #1217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses Issue #1217 , focusing on enhancing error handling and input constraints within the
forward()method. The key change involves enforcing a length constraint onio_signatureto ensureforward()only accepts a single pandas DataFrame as input.